Does not build against PHP > 7.1

sebastianbergmann commented 5 years ago

/bin/sh /usr/local/src/php/ui/libtool --mode=compile cc -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -I. -I/usr/local/src/php/ui -DPHP_ATOM_INC -I/usr/local/src/php/ui/include -I/usr/local/src/php/ui/main -I/usr/local/src/php/ui -I/usr/local/php-7.2/include/php -I/usr/local/php-7.2/include/php/main -I/usr/local/php-7.2/include/php/TSRM -I/usr/local/php-7.2/include/php/Zend -I/usr/local/php-7.2/include/php/ext -I/usr/local/php-7.2/include/php/ext/date/lib  -DHAVE_CONFIG_H  -march=native -mtune=native -fdiagnostics-color=auto -O2 -fPIC -pipe   -c /usr/local/src/php/ui/classes/box.c -o classes/box.lo 
 cc -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -I. -I/usr/local/src/php/ui -DPHP_ATOM_INC -I/usr/local/src/php/ui/include -I/usr/local/src/php/ui/main -I/usr/local/src/php/ui -I/usr/local/php-7.2/include/php -I/usr/local/php-7.2/include/php/main -I/usr/local/php-7.2/include/php/TSRM -I/usr/local/php-7.2/include/php/Zend -I/usr/local/php-7.2/include/php/ext -I/usr/local/php-7.2/include/php/ext/date/lib -DHAVE_CONFIG_H -march=native -mtune=native -fdiagnostics-color=auto -O2 -fPIC -pipe -c /usr/local/src/php/ui/classes/box.c  -fPIC -DPIC -o classes/.libs/box.o
/usr/local/src/php/ui/classes/box.c:188:91: error: macro "ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX" passed 6 arguments, but takes just 5
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(php_ui_box_is_padded_info, 0, 0, _IS_BOOL, NULL, 0)
                                                                                           ^
In file included from /usr/local/php-7.2/include/php/main/php.h:39,
                 from /usr/local/src/php/ui/classes/box.c:22:
/usr/local/php-7.2/include/php/Zend/zend_API.h:128:30: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘}’ token
 #define ZEND_END_ARG_INFO()  };
                              ^
/usr/local/src/php/ui/classes/box.c:192:1: note: in expansion of macro ‘ZEND_END_ARG_INFO’
 ZEND_END_ARG_INFO()
 ^~~~~~~~~~~~~~~~~
In file included from /usr/local/php-7.2/include/php/main/php.h:39,
                 from /usr/local/src/php/ui/classes/box.c:22:
/usr/local/src/php/ui/classes/box.c:217:31: error: ‘php_ui_box_is_padded_info’ undeclared here (not in a function); did you mean ‘php_ui_box_set_padded_info’?
  PHP_ME(Box, isPadded,        php_ui_box_is_padded_info, ZEND_ACC_PUBLIC)
                               ^~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/php-7.2/include/php/Zend/zend_API.h:70:75: note: in definition of macro ‘ZEND_FENTRY’
 #define ZEND_FENTRY(zend_name, name, arg_info, flags) { #zend_name, name, arg_info, (uint32_t) (sizeof(arg_info)/sizeof(struct _zend_internal_arg_info)-1), flags },
                                                                           ^~~~~~~~
/usr/local/php-7.2/include/php/main/php.h:422:25: note: in expansion of macro ‘ZEND_ME’
 #define PHP_ME          ZEND_ME
                         ^~~~~~~
/usr/local/src/php/ui/classes/box.c:217:2: note: in expansion of macro ‘PHP_ME’
  PHP_ME(Box, isPadded,        php_ui_box_is_padded_info, ZEND_ACC_PUBLIC)
  ^~~~~~
make: *** [Makefile:207: classes/box.lo] Error 1

sebastianbergmann commented 5 years ago

Looks like this would be fixed by #42 or #51. Sorry for the noise.

NyaomiDEV commented 5 years ago

Is it actually fixed?

dmvdbrugge commented 5 years ago

No it's not, see https://github.com/krakjoe/ui/pull/51#issuecomment-399323385 @krakjoe has been silent after that

scottdnz commented 5 years ago

If anyone's interested, I've been blogging about getting things going in Ubuntu using the workaround(s)... http://scriptsonscripts.blogspot.com/2019/02/desktop-php-7-with-ui-extension-libui.html http://scriptsonscripts.blogspot.com/2019/03/a-desktop-gui-form-with-php-ui-extension.html

krakjoe / ui

Does not build against PHP > 7.1 #53