Symfony options-resolver fails when ext-uopz is enabled

NikoGrano commented 5 years ago

https://github.com/symfony/symfony/issues/29842

stof commented 5 years ago

See https://github.com/symfony/symfony/issues/29842#issuecomment-453446591 for an analysis of the issue.

krakjoe commented 5 years ago

I'm able to reproduce the bus error with 5.1.0 and xdebug enabled as in your configuration ... I'm not able to reproduce with HEAD and xdebug enabled, so I think solved, but I'll leave this for you to close ...

NikoGrano commented 5 years ago

Thanks @krakjoe! I will wait for new release and inform if this problem will continue!

I will close this issue when I can confirm latest version doesn't cause problems anymore.

stof commented 5 years ago

this might be the same than https://github.com/krakjoe/uopz/issues/98 btw.

krakjoe commented 5 years ago

It may be, but I couldn't reproduce the issue when the bug was posted, and when I asked the OP to try again, they said they couldn't compile and weren't using uopz anymore ... so I don't really know what to do with that ...

krakjoe commented 5 years ago

@stof are you able to produce anything like #98 ?

It's highly likely to be fixed, 6.0.0 cuts interference with the engine a lot ... but if I can get a reproducing case and someone open to communication, I'm very happy to make sure ....

croensch commented 5 years ago

I can trigger it on php-7.2.13 + uopz-5.1.0 with:

<?php
$c = 'Bogus';
$o = new stdClass;
echo ($o instanceof $c);

Fatal error does not happen with uopz-5.0.2

NikoGrano commented 5 years ago

@croensch That is highly possible. But can you reproduce it with 6.x? As far I understand there is no sense to make fix for 5.x as 6.x is closing...

krakjoe commented 5 years ago

This is very frustrating, I'm not able to reproduce that bug with 7.2.13 and uopz v5.1.0 ... so I've nothing to compare it too ... I've tried with and without opcache, with and without xdebug, I've tried with and without zend mm, I've tried valgrind ... nothing ... I can't make a fault, error, or memory error of any sort ... just bool(false) everywhere ...

Can you show me php -v output, are you on windows or a mac maybe ? Have you got any other particularly magical/non-standard extensions loaded ?

I'm stabbing in the dark ... thanks for taking the time though ...

croensch commented 5 years ago

I'm on amazonlinux (centos-ish) here you have a Dockerfile to reproduce it: https://gist.github.com/croensch/7b5bd12986585459a4e9c714f3a9afdc

krakjoe commented 5 years ago

Thankyou.

Can confirm that #98 is no longer an issue with 6.0.0

FROM amazonlinux:2

RUN amazon-linux-extras install epel
RUN amazon-linux-extras install php7.2=7.2.13
RUN yum install -y http://rpms.remirepo.net/enterprise/remi-release-7.rpm && \
    yum install -y yum-utils && \
    yum-config-manager --enable remi-safe
RUN yum install -y --enablerepo=remi-php72 php-mbstring php-pecl-libsodium
RUN yum install -y --enablerepo=remi-php72 php-devel
RUN yum install -y git build-essential gcc make
RUN git clone https://github.com/krakjoe/uopz && \
    cd uopz && \
    phpize && \
    ./configure && \
    make install

COPY bogus.php .

ENTRYPOINT ["php"]
CMD ["bogus.php"]

krakjoe commented 5 years ago

6.0.0 available in pecl and from remi, windows builds are still running, will appear here before links on pecl ...

krakjoe commented 5 years ago

@Niko9911 are we done here ?

NikoGrano commented 5 years ago

I Will check this today

NikoGrano commented 5 years ago

I've tested all cases I had issues and some extra. Would consider as closed & fixed. Thanks!

krakjoe / uopz

Symfony options-resolver fails when ext-uopz is enabled #101