search

krakjoe / uopz

User Operations for Zend
Other
358 stars 47 forks source link

Make UOPZ compatible with XDebug again #125

Closed SMillerDev closed 4 years ago

SMillerDev commented 4 years ago

As suggested by @cmb69 in https://github.com/krakjoe/uopz/issues/122#issuecomment-605967700

I have no idea about the C code so I might need someone to point me to problems here.

remicollet commented 4 years ago

Better to also add a constraint in the package.xml

diff --git a/package.xml b/package.xml
index 8dd9afc..43ac313 100644
--- a/package.xml
+++ b/package.xml
@@ -134,6 +134,11 @@ It supports the following activities:
    <pearinstaller>
     <min>1.10</min>
    </pearinstaller>
+   <extension>
+    <name>xdebug</name>
+    <max>2.9.3</max>
+    <conflicts />
+   </extension>
   </required>
  </dependencies>
  <providesextension>uopz</providesextension>

This will result in following error message pecl/uopz conflicts with PHP extension "xdebug" (version <= 2.9.3), installed version is 2.9.3

SMillerDev commented 4 years ago

Done.

SMillerDev commented 4 years ago

Anything I can still do here to help?

cmb69 commented 4 years ago

Would be great if @krakjoe could review this PR.

SMillerDev commented 4 years ago

Can this be merged without that review?

krakjoe commented 4 years ago

@cmb69 merge it please @remicollet I think probably a release is in order for this one, please

remicollet commented 4 years ago

Merged

SMillerDev commented 4 years ago

Thanks for all the work people

remicollet commented 4 years ago

@remicollet I think probably a release is in order for this one, please

@krakjoe 6.1.2 released

BTW, can you pleasde have a look at travis results, seems we have some failure when opcache is enabled (7.4 only)

krakjoe commented 4 years ago

Thanks && ack

On Tuesday, 30 June 2020, Remi Collet notifications@github.com wrote:

@remicollet https://github.com/remicollet I think probably a release is in order for this one, please

@krakjoe https://github.com/krakjoe 6.1.2 released

BTW, can you pleasde have a look at travis results, seems we have some failure when opcache is enabled (7.4 only)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/krakjoe/uopz/pull/125#issuecomment-651766786, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARB52XFYVPTTU7EHPQVIWLRZHMZNANCNFSM4NBNAP3Q .