krakjoe / uopz

User Operations for Zend
Other
356 stars 47 forks source link

Directly accessing op_array.static_variables is no longer supported #131

Closed cmb69 closed 3 years ago

cmb69 commented 4 years ago

As of PHP 7.4.0, immutable op_arrays are no longer copied to process memory. op_array.static_variables may refer to mutable data in the process memory, though, so we have to use the indirection offered via the ZEND_MAP_PTR_*() macros to reliably get at the desired data.

cmb69 commented 4 years ago

-5 failing tests, but I'm not sure whether I'm using the ZEND_MAP_PTR_*() API correctly.

cmb69 commented 4 years ago

Oh, almost forgot that this needs overhaul.

krakjoe commented 3 years ago

@cmb69 if you want to take another look at this, I hope to do a release soon-ish ...

merge when ready ...

krakjoe commented 3 years ago

Fixed in d4aa3d39264c8ae7cb755a2b50f9c872867714fb