krakowski / gradle-jextract

Gradle plugin for integrating Project Panama's jextract tool
https://plugins.gradle.org/plugin/io.github.krakowski.jextract
GNU General Public License v3.0
53 stars 10 forks source link

Fix jextract executable search logic on Windows #4

Closed Arc-blroth closed 3 years ago

Arc-blroth commented 3 years ago

Currently, this plugin only seems to search for the JExtract executable with a path of bin/jextract. However, this doesn't work on Windows since Windows executables also have a .exe extension.

This PR adds in a bit of extra logic to detect if the buildsystem is Windows, and if so, look for bin/jextract.exe instead of just bin/jextract.

Also thanks for making this plugin!

krakowski commented 3 years ago

Hi @Arc-blroth,

Thanks for your interest and this PR! The changes look good. If there are any further problems, I'm happy to help :slightly_smiling_face:

I will release a new version in the Gradle Plugin Portal shortly, so the new version can be used immediately.