search

krakrjak / fits-parse

Parse FITS files for Astronomy data analysis.
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Commit cabal file to allow projects to depend on git commits #7

Closed seanhess closed 2 months ago

seanhess commented 3 months ago

Remove .cabal file from the .gitignore and commit to the repo. This allows one to depend on github branches via source-repository-package

-- cabal.project
source-repository-package
  type: git
  location: https://github.com/seanhess/fits-parse.git
  tag: 7828eb88957e2a93ffebf90974523dc4845a0c61
seanhess commented 2 months ago

Hey @krakrjak can we get this merged? It looks like the last PR hasn't been released on hackage, and I'd like to depend on your github in the meantime. Without this PR, I have to depend on my fork, even though the main repo has those changes merged

krakrjak commented 2 months ago

Yeah, give me the weekend to sort this out and cut a real release. The intention was to make a 0.4.0 release a while back and I just didn't get to it.

krakrjak commented 2 months ago

I'm not sure about this as the cabal file is generated and submitted as part of the src-dist.

What I want is the most compatible src layout for others to use, but this Cabal file is not suitable for uploading to hackage for inclusion in stackage. I have a special process to generate the src-dist package for upload.

Let me tinker with this and your suggestion about downstream cabal usage. I'll probably have more questions.

krakrjak commented 2 months ago

Maybe the right answer here for long-term support and ease of onboarding new users/developers is to drop the hpack usage completely and just give over to cabal + stack support. I think it's just time to transition to native cabal. It will also simplify release processes.

seanhess commented 2 months ago

Sounds good!

On Sun, Jul 28, 2024 at 8:55 AM Zac Slade @.***> wrote:

Merged #7 https://github.com/krakrjak/fits-parse/pull/7 into main.

— Reply to this email directly, view it on GitHub https://github.com/krakrjak/fits-parse/pull/7#event-13671614966, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAD66NTCTB254WLH3AZRD3ZOUH7XAVCNFSM6AAAAABKIFHAFCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGY3TCNRRGQ4TMNQ . You are receiving this because you authored the thread.Message ID: @.***>