search

kramdown / parser-gfm

kramdown-parser-gfm provides a kramdown parser for the GFM dialect of Markdown
Other
56 stars 14 forks source link

Extract gemspec as a file? #25

Closed timdiggins closed 3 years ago

timdiggins commented 3 years ago

I found it a bit surprising that the gemspec was embedded in Rakefile rather than tracked as a separate file. Would it be possible/acceptable to extract it out? It would make it easier for new developers I think, as well as useful for gem users to see this history of this specific file.

ashmaroli commented 3 years ago

pinging @gettalong for the reason behind current workflow.

gettalong commented 3 years ago

I guess the correct description would be "historic reasons" :smile: It is just the way I implemented the development infrastructure for the last ~18 years.

Another reason, later on, was so that the kramdown repo couldn't be used in a Gemfile. If someone wanted to use an unreleased version they would have needed to clone the repo and add the gemspec themselves, making it a more conscious choice.

ashmaroli commented 3 years ago

just the way I implemented the development infrastructure for the last ~18 years.

Okay, are you open to changing that dev workflow for this repository, @gettalong? I'll do the needful if you're on board..

gettalong commented 3 years ago

@ashmaroli Yeah, just go ahead!

timdiggins commented 3 years ago

Thank you!