search

kramdown / parser-gfm

kramdown-parser-gfm provides a kramdown parser for the GFM dialect of Markdown
Other
56 stars 14 forks source link

Set up Continuous Integration with Travis CI #6

Closed ashmaroli closed 5 years ago

ashmaroli commented 5 years ago

Resolves #1

ashmaroli commented 5 years ago

CI fails with following output:

  1) Failure:
TestFiles#test_gfm_/home/travis/build/kramdown/parser-gfm/test/testcases/backticks_syntax_text_to_html [/home/travis/build/kramdown/parser-gfm/test/test_files.rb:32]:
--- expected
+++ actual
@@ -7,15 +7,9 @@
 <pre><code>Unbalanced bottom heavy
 </code></pre>

-<div class=\"language-ruby highlighter-coderay\"><div class=\"CodeRay\">
-  <div class=\"code\"><pre><span class=\"line-numbers\"><a href=\"#n1\" name=\"n1\">1</a></span>language no space
-</pre></div>
-</div>
-</div>
+<pre><code class=\"language-ruby\">language no space
+</code></pre>

-<div class=\"language-ruby highlighter-coderay\"><div class=\"CodeRay\">
-  <div class=\"code\"><pre><span class=\"line-numbers\"><a href=\"#n1\" name=\"n1\">1</a></span>language with space
-</pre></div>
-</div>
-</div>
+<pre><code class=\"language-ruby\">language with space
+</code></pre>
 "
ashmaroli commented 5 years ago

@gettalong Should I rewrite all expectations to use Rouge..?

gettalong commented 5 years ago

That should probably be done, yes. I tested the GFM parser before I extracted the syntax highlighter, so it works correctly.

ashmaroli commented 5 years ago

I've now set up to test with both Rouge 2.x and Rouge 3.x. Feel free to make changes directly to this branch if you want.

ashmaroli commented 5 years ago

Gentle reminder: Knock! knock!

gettalong commented 5 years ago

I'm okay with the changes but please only merge after I released kramdown 2.0.0 this weekend.