krames12 / pugcheck-nodejs

A simple character lookup for raid leaders and recruitment officers in World of Warcraft guilds.
1 stars 2 forks source link

Declare a Node Engine #6

Open Ellisande opened 8 years ago

Ellisande commented 8 years ago

Declare the version of node the project uses by using the engines property of the package.json. Helps contributors know what syntax will work at runtime, and make sure they are running it correctly locally. Generally good practice to use the latest LTS version of node available, which is currently the 6.x build.

{
  "name": "warcarft-character-progress",
  "version": "1.0.0",
  "description": "A simple character progression lookup tool for raid leaders and recruitment officers in World of Warcraft guilds and raid teams.",
  "main": "server.js",
   "engines": {
     "node": "6.x"
  },
  "scripts": {
    "start": "node server.js"
  },
  "keywords": [
    "warcraft"
  ],
  "author": "Nick Kramer",
  "license": "ISC",
  "dependencies": {
    "body-parser": "^1.15.2",
    "ejs": "^2.5.1",
    "express": "^4.14.0",
    "request": "^2.74.0"
  }
}
krames12 commented 8 years ago

Definitely good to know and I was unsure if using the "Stable 4.4.x" or using the "LTS 6.x" was the standard way of doing things. I'm currently running 4.4.5 in my dev environment so I will see if there are any conflicts before rolling this out.