krasa / GrepConsole

IntelliJ plugin - https://plugins.jetbrains.com/plugin/7125
Apache License 2.0
440 stars 57 forks source link

Unreadable text when errors contain source link #106

Closed cowwoc closed 6 years ago

cowwoc commented 6 years ago

By default ERROR lines are colored black foreground on light brown background. However, if the ERROR contains a source-link (e.g. output from a compiler error) then we end up with light blue foreground on a light brown background and the result is unreadable. screenshot

krasa commented 6 years ago

Well, what do you propose to do?

cowwoc commented 6 years ago

Either change the default color to something that would work better with links, or suppress the special link foreground color for lines that get a special background color.

krasa commented 6 years ago

How about this:

image

krasa commented 6 years ago

Or dark yellow for WARN image

krasa commented 6 years ago

And black for FATAL 👍 image

cowwoc commented 6 years ago

The first combination in the first response is the easiest to read, in spite of the fact that you used green for WARN which is kind of the opposite of what you want for warnings. That said, I'll take green for warnings any day of the week so long as the result is readable ;)

The only color combination I still find a bit hard to read is the links (light blue foreground) with a dark red background.

Would it looks weird if we avoid changing the background color for links (just color the leading text)?

krasa commented 6 years ago

Yeah that green is nice, but not for WARN :)

Dark yellow has bad contrast to background and to text, but I found a good alternative - violet. And red would maybe work better with lower brightness, but it will never be great against blue font: image

It may not be great, but at least it is readable.

I just found out that you can actually do this: File | Settings | Editor | Color Scheme | General | Hyperlinks and add background there. image

cowwoc commented 6 years ago

Honestly, the best solution I've seen so far is violet as you suggested and disabling background colors for hyperlinks. The line is still visibly highlighted without changing the background color of links.