search

krasa / GrepConsole

IntelliJ plugin - https://plugins.jetbrains.com/plugin/7125
Apache License 2.0
437 stars 57 forks source link

Dark theme compatibility #114

Closed Vampire closed 6 years ago

Vampire commented 6 years ago

The out-of-the-box settings of your plugin are not very dark theme friendly. If you just install the plugin and open the console, the TRACE level logging e. g. is totally unreadable:

grafik

With highlighting disabled it looks like this

grafik

krasa commented 6 years ago

Try to click on reset settings

Vampire commented 6 years ago

You mean "Reset all to default"? Doesn't change anything.

krasa commented 6 years ago

Ok. TRACE has lower contrast by design, but it may be too low for you and your monitor. So just change it.

And if you have a better idea how to color it, then tell me.

Vampire commented 6 years ago

It is fine if you have a light theme where it is black on white. But on a dark theme? On what monitor does black on dark grey have enough contrast to be readable properly? o_O

krasa commented 6 years ago

I have used it that way for years just fine, on at least 6 different monitors with a contrast and brightness way down.

Vampire commented 6 years ago

Can you actually read the text in my first screenshot sufficiently?

Vampire commented 6 years ago

Not the DEBUG lines, the TRACE lines I mean

krasa commented 6 years ago

Sure, when I open it in fullscreen so I have no white around. image

Vampire commented 6 years ago

I find this unreadable even on fullscreen, but ok. Thought it might just be a bug as many ppl don't use TRACE level logging or don't enable it. If it is intentionally that way, then I simply consider changing it or leave the hightlighting disabled.