Wrong breakpoint/gutter icons

krasa / IdeaIconPack

UX friendly old colorful icons for IntelliJ 2018.2+ solving https://youtrack.jetbrains.com/issue/IDEA-192025

https://plugins.jetbrains.com/plugin/10777

Apache License 2.0

31 stars 5 forks source link

Wrong breakpoint/gutter icons #8

Open Phoenix616 opened 5 years ago

Phoenix616 commented 5 years ago

When selecting the 2016.2 icons following icons seem to be using the new design/wrong icon:

Temporary/remove once hit breakpoints. (Showed with a 1 in the circle previously, now shows the normal breakpoint icon)
Non-suspension breakpoint uses new design
Interface implementation gutter icons use new design
Subclassed abstract class gutter uses new design

Is this because of the + some from 2018.1 part? If so I would prefer it if one could have a pure 2016.2 icon pack (or manually select which icons to use for which option)

krasa commented 5 years ago

maybe jetbrains removed that icon feature
and added this icon feature, that's why it uses new icons.
not sure what is going on here, but at least they look similar

Phoenix616 commented 5 years ago

Would be ideal if the non-suspension breakpoint were at least in the style of the old ones. Edit: Also I could've sworn that there was a different icon for non-suspending breakpoints before too.

Phoenix616 commented 5 years ago

Found another icon that seems to use the new design:

The icon in the popup when pressing alt+enter on a missing class

krasa commented 5 years ago

Well, I am kinda fine with all that, as long as the icon is not a complete colorless garbage.

Phoenix616 commented 5 years ago

Well they aren't the 2016.2 icons and therefore a bug ¯\_(ツ)_/¯

krasa commented 5 years ago

Well, I don't have '2016.2 only' option (ᵔᴥᵔ)

Phoenix616 commented 5 years ago

Regarding the non-suspension breakpoint: I think it just used to display the breakpoint icon without anything in it before (debugger/db_set_breakpoint.png) so it could just use that (or a version of that icon that has a color shift applied) for the new db_no_suspend_breakpoint. The temporary breakpoint seems to still be included in the icons.jar of the latest version though (but using the old design) so no idea why it doesn't display, might be a bug in the program itself.

Regarding the override/interface icons: I'm not exactly sure why they look different to me, theym seem to be the same ones as they were before. Maybe they changed something about the scaling of the icons which changed the rendering slightly :thinking:

krasa commented 5 years ago

Regarding the override/interface icons: they now use svg one. That was added recently so the plugin does not cover it.