krasa / MavenHelper

IntelliJ plugin - https://plugins.jetbrains.com/plugin/7179
Apache License 2.0
253 stars 91 forks source link

IDEA 2022.2: Toolbar icons don't update/show on start and "Run Maven Goal" is not shown unless on file. #93

Open bitstrings opened 2 years ago

bitstrings commented 2 years ago

In toolbar, maven helper custom icons don't load unless editing or applying Maven Helper settings.

In toolbar, "Run Maven Goal" doesn't appear unless you're in editor.

IDEA Version: 2022.2

krasa commented 2 years ago

they are not made for the toolbar

bitstrings commented 2 years ago

Maybe you didn't intend for then being used in the toolbar but goals are registered as Actions.

Using some basic goals, like package or clean install as toolbar items is natural and efficient.

krasa commented 2 years ago

you can try it: MavenRunHelper.zip

bitstrings commented 2 years ago

Doesn't seem to make a difference.

My attempt to record a video showing the issues. https://drive.google.com/file/d/1UiZVn85hptPYTfSBY9f3tZI_Ldzjjnam/view?usp=sharing

I don't know if this helps you.

On Sun, Jul 31, 2022 at 12:09 PM Vojtěch Krása @.***> wrote:

you can try it: MavenRunHelper.zip https://github.com/krasa/MavenHelper/files/9229246/MavenRunHelper.zip

— Reply to this email directly, view it on GitHub https://github.com/krasa/MavenHelper/issues/93#issuecomment-1200453632, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG6OPNVKGOXA6RJOX3ZDRLVW2QMNANCNFSM55DUF26A . You are receiving this because you authored the thread.Message ID: @.***>

--

krasa commented 2 years ago

Yes, that one action was quite problematic... This should work: MavenRunHelper.zip

bitstrings commented 2 years ago

Cool - icons are now visible from start and work.

The only issue remaining is the custom icon for my "clean install" action is still the default unless I play with the settings.

On Sun, Jul 31, 2022 at 3:16 PM Vojtěch Krása @.***> wrote:

Yes, that one action was quite problematic... This should work: MavenRunHelper.zip https://github.com/krasa/MavenHelper/files/9229554/MavenRunHelper.zip

— Reply to this email directly, view it on GitHub https://github.com/krasa/MavenHelper/issues/93#issuecomment-1200483071, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG6OPIOF2MNV75TGWUYLJLVW3GH7ANCNFSM55DUF26A . You are receiving this because you authored the thread.Message ID: @.***>

--

krasa commented 2 years ago

ok, it should work unless you import more modules, then it requires context, just like VCS History button MavenRunHelper.zip

bitstrings commented 2 years ago

Well, it's much better because the actions are now usable and visible.

But the custom icon for my "clean install" doesn't seem to work until I reapply the settings.

On Sun, Jul 31, 2022 at 3:55 PM Vojtěch Krása @.***> wrote:

ok, it should work unless you import more modules, then it requires context, just like VCS History button MavenRunHelper.zip https://github.com/krasa/MavenHelper/files/9229619/MavenRunHelper.zip

— Reply to this email directly, view it on GitHub https://github.com/krasa/MavenHelper/issues/93#issuecomment-1200488963, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG6OPNHJMGZLK62NYHSJITVW3KZVANCNFSM55DUF26A . You are receiving this because you authored the thread.Message ID: @.***>

--

krasa commented 2 years ago

strange, works fine for me. is there something in the log? Or how does it not work?