search

krasa / VisualVMLauncher

IntelliJ plugin - https://plugins.jetbrains.com/plugin/7115
Apache License 2.0
107 stars 19 forks source link

Add vector icons matching IntelliJ 2018.2 theme #27

Closed tan9 closed 5 years ago

tan9 commented 5 years ago

Matching the new icon style introduced in IntelliJ 2018.2.

Now looks like: Screenshot from 2019-06-14 17-49-34

tan9 commented 5 years ago

@krasa is the icons in this PR meet the quality requirements of this plugin?

krasa commented 5 years ago

It's beautiful ❤️

krasa commented 5 years ago

Only, is there any particular reason why the color is more yellow, than the logo? image image

tan9 commented 5 years ago

Hi @krasa, I just picked the color from Color of Action Icons listed in the IntelliJ Platform UI Guidelines. There are only 4 colors in addition to grey allowed, so strict!

Although there exists wider colors in Noun Icons palette for use in tree views. But since our icon is located in the toolbar. It should be a good idea not to try to clutter it up :)

tan9 commented 5 years ago

In #28, I changed the console16.svg and its dark variant to grey color according to the guideline.

krasa commented 5 years ago

Well, I think the whole gray style of icons is a collosal mistake. That's why I have https://github.com/krasa/IdeaIconPack

More so after they've made a theme contest which goes against everythig they've done https://plugins.jetbrains.com/contest/intellij-themes/2019

Orange is an established color of VisualVM's logo, so it should be that. It will look good everywhere, but gray one would look disabled for people that have colorful themes.