search

krasimir / ktcom-comments

Comments made on https://krasimirtsonev.com/blog
MIT License
0 stars 0 forks source link

Octomments - use GitHub issues as a comment plugin #628

Open krasimir opened 4 years ago

krasimir commented 4 years ago

Article 👉 https://krasimirtsonev.com/blog/article/octomments-github-issues-as-comment-plugin

87% of my readers are using Chrome on desktop. This means that I have the luxury to care less about performance. However I just recently found that this blog has 56 (out of 100) points on Google's pagespeed test. That's not good. The report says that my Disqus comments are blocking the main thread for ~900ms. I want comments on my blog but I also want my users to reach to content as quickly as possible. So, after so many years using Disqus I decided to break with it and use something else ... continue reading

simevidas commented 4 years ago

Writing a comment because I want to test this.

Updating the comment on GitHub’s website.

👍 The updated comment shows up on the website ~after a reload~ after a few moments.

krasimir commented 4 years ago

@simevidas looks like it's working :) You are giving me a good idea. To add a second request after a timeout.

michael-klein commented 4 years ago

Testing the comments, too :)

michael-klein commented 4 years ago

Okay, this is really neat. I think I'll make use of this in the future. Good job!

krasimir commented 4 years ago

Thanks @michael-klein. Let me know if you have any issues.

MartinMuzatko commented 4 years ago

this is nice!

MartinMuzatko commented 4 years ago

Would be nicer, if I'd be forwarded to the comment section again after logging in.

MartinMuzatko commented 4 years ago

wait.. does this support markdown? And HTML? In this case you probably want to filter what to show via options. https://www.petmd.com/sites/default/files/choking-heimlich-maneuver-cats.png

krasimir commented 4 years ago

Hm ... the library should focus the textarea again after login. At least that's how it is under Chrome.

As for the markdown - that's completely on GitHub's API. I was thinking to add a preview support but this means bundling a markdown parser in the library which is overkill atm. One of my main goals was to provide a tiny lib.

MartinMuzatko commented 4 years ago

When logging in again, everything works fine. It was just the first signup granting the permissions.

Another benefit I just discovered: you basically get notifications when someone commented for free!. And you can instantly stalk them on GitHub :P

MartinMuzatko commented 4 years ago

Just a last test :)

krasimir commented 4 years ago

Another benefit I just discovered: you basically get notifications when someone commented for free!

Exactly :)

krasimir commented 4 years ago

Testing again.

CyberShadow commented 2 years ago

The "act on your behalf" permission is super scary, no way would I authorize an app on my work account, for example.

But, it's nice that you can just comment on the issue directly.

Perhaps using Discussions comments would be better, as those have threading (albeit only up to one level).