Example - Githubissues

krasimir commented 4 years ago

Demo.

krasimir commented 4 years ago

Octomments is a comment plugin based on GitHub issues. Try posting a comment below.

panayotoff commented 4 years ago

I think it looks awesome.

waqid commented 4 years ago

rilly?

krasimir commented 4 years ago

Ah so we have a second comment appearing. It looks like it is indeed working :D

iamandrewluca commented 4 years ago

Let's try some emojis :fire: :100: :rotating_light:

KhanMaytok commented 4 years ago

ok it's good

dermoumi commented 4 years ago

Testing

meduzen commented 4 years ago

Are all these permissions are necessary to allow log-in + comment? I don’t plan to dig and read GitHub permissions doc, but it should raise people attention.

machineghost commented 4 years ago

This is a cool idea! But on a (mostly) unrelated tangent:

in your page's <head> tag:

Why even use<head> tags, especially if you care about performance?

Google's own guidelines now encourage you to do what the HTML spec has said was ok for awhile now: leave <html>, <head>, and <body> tags out of your HTML.

They add nothing except page weight, as every browser will infer them, and treat the page identically whether they are there or not.

Now, we're talking a tiny number of characters in the grand scheme, so it's not a meaningful performance enhancement .. but again, there's zero benefit to including those tags today.

ajbogh commented 4 years ago

Suggestion, change "number" to "issueNumber" so people know what it represents.

Add documentation on how to resolve/approve or reject comments. I don't know if that would be adding a thumbs-up or thumbs-down and filtering on those or providing a method of deleting comments (if possible).

I also assume this allows all of the github markdown, which is pretty cool.

ahmadalfy commented 4 years ago

Didn't read LUL

ahmadalfy commented 4 years ago

test

var x = []

DylanTackoor commented 4 years ago

wat

DylanTackoor commented 4 years ago

This is a cool idea! But on a (mostly) unrelated tangent:

in your page's <head> tag:

Why even use<head> tags, especially if you care about performance?

Google's own guidelines now encourage you to do what the HTML spec has said was ok for awhile now: leave <html>, <head>, and <body> tags out of your HTML.

They add nothing except page weight, as every browser will infer them, and treat the page identically whether they are there or not.

Now, we're talking a tiny number of characters in the grand scheme, so it's not a meaningful performance enhancement .. but again, there's zero benefit to including those tags today.

Where do they suggest this? Would love to read more!

karpatic commented 4 years ago

This is cool! This very comment you are reading has been submitted, and then later edited! On GitHub this comment is set to hidden; The comment is not being hidden in the thread though.

aleen42 commented 4 years ago

I have wrriten one myself for integrating Gitbook under GitHub or Gitlab, gitbook-comments.

machineghost commented 4 years ago

Where do they suggest this? Would love to read more!

https://google.github.io/styleguide/htmlcssguide.html#Optional_Tags

dmitriigaidarji commented 4 years ago

IMG_20200202_124638_290

krasimir commented 4 years ago

Thank you all for the comments. I'll soon release a new version that addresses the problems mentioned above.

Neodark7 commented 4 years ago

Awesome !

stavgayer commented 4 years ago

fmt.Println("Testing")

Testing

[ ] Testing No.1
[ ] Testing No.2

yuriy636 commented 4 years ago

test

Twixes commented 4 years ago

Nice

Q00 commented 4 years ago

this is test

lataupe78 commented 4 years ago

Good job 👍😉

amilajack commented 4 years ago

Sweet!

garyjohngoofer commented 4 years ago

What permissions does this require on my account?

garyjohngoofer commented 4 years ago

turns out, a lot of them

Shuunen commented 4 years ago

Really good idea you had 👍💎

saenzramiro commented 4 years ago

Good idea!

krasimir commented 4 years ago

@meduzen @garyjohngoofer Octomments now uses less permissions from the commenters. However the owner of the site should install Octomments app. Which I think is fare.

@ajbogh number changed to issueNumber (thanks for the suggestions. It totally make sense).