search

krasimir / octomments

A small library that offers GitHub issues as comments for your site/blog
https://ocs.now.sh/
MIT License
284 stars 15 forks source link

Thoughts and questions #18

Closed 262media closed 3 years ago

262media commented 4 years ago

In first place, thanks for sharing this project, at a first glance sounds cool. I do have 2 questions for you: 1- What's wrong about loading Discus and their great (with heavy payload) features only "on demand" ? ( for the visitors who wants to read / write comments ) 2 - why does octomments needs me to allow to be able to read and write all my public repository data (and i know it's public) . This includes the following: -Code -Issues -Pull requests -Wikis -Settings -Webhooks and services -Deploy keys

Thanks again for sharing Rui S.

krasimir commented 4 years ago

Hey,

1- What's wrong about loading Discus and their great (with heavy payload) features only "on demand" ? ( for the visitors who wants to read / write comments )

Sure I can put some more engineering and load Discuss later but this still takes the main tread time to execute. Also I didn't like the heavy block. By heavy I mean big in content size. Too many things are rendered.

2 - why does octomments needs me to allow to be able to read and write all my public repository data (and i know it's public)

I'm just changing this. It will be probably just your public information.

262media commented 4 years ago

Looks really good. I'll keep an eye on this project. Thank you once more for sharing