search

krasimir / octomments

A small library that offers GitHub issues as comments for your site/blog
https://ocs.now.sh/
MIT License
284 stars 15 forks source link

Link to post comment via github instead of textbox/oauth? #35

Open atymic opened 3 years ago

atymic commented 3 years ago

I don't like giving permissions to random things. Any chance we can have a flag to just put a link to the issue instead of forcing them to oauth?

Happy to PR :)

krasimir commented 3 years ago

Hey,

there is a link to the issue already. For example here https://krasimirtsonev.com/blog/article/transpile-to-esm-with-babel#comments Screenshot 2021-01-17 at 10 03 08

krasimir commented 3 years ago

Or you can put a paragraph above/below the form saying "Feel free to comment directly on GitHub here".

atymic commented 3 years ago

I was more thinking of a flag to disable the textbox/field, and replace it with a "Click here to comment via Github"

I'll fork and have a go at some point, but was wondering if it was something you'd accept back into the project 👍

krasimir commented 3 years ago

Oh yes definitely. Happy to review a PR for such feature.