search

krasserm / akka-persistence-kafka

A replicated Akka Persistence journal backed by Apache Kafka
Apache License 2.0
201 stars 59 forks source link

Curator is a runtime dependency #21

Closed crispywalrus closed 9 years ago

crispywalrus commented 9 years ago

Nothing huge here but curator is being delivered as a runtime dependency. I'll submit a pull request with curator and test server moved to test config

krasserm commented 9 years ago

Curator is used for running a test server i.e. the runtime dependency was intentional. Making it a test dependency excludes the test server from the published jar file. It would be probably better to provide a separate *-test.jar file, if you don't want to have the test server included as runtime dependency. WDYT?

crispywalrus commented 9 years ago

Building a test dependency would work, as long as the runtime dependency on curator is removed. For myself I intent to completely dike out the test servers and just run kafka an zookeeper for development anyway but I'd like to keep using the published artifacts.

krasserm commented 9 years ago

Ok, then let's go for an additional -test.jar. Do you want to make that contribution?

crispywalrus commented 9 years ago

I've updated my fork, and hence pr #22, to publish test artifacts.