krasserm / bayesian-machine-learning

Notebooks about Bayesian methods for machine learning
Apache License 2.0
1.8k stars 460 forks source link

Potential Typo in Eq 12 #11

Closed DodoTheDeveloper closed 4 years ago

DodoTheDeveloper commented 4 years ago

Greetings,

I think there might be a typo in equation 12, where the log of the posterior is calculated.

image

In equation 6 there is a minus before E_D and it looks like it has been overlooked, when using the log prior in equation 12.

image

When trying to derivate the log posterior by using Bayes Theorem I almost got the same solution as in this article but was not able to find my error with the sign.

While reading Pattern Recognition and Machine Learning from Bishop(2006) I saw on page 153 equation 3.55 I found support of my theory that there might be a missing sign.

I created a PR #12. If I'm wrong please just close the request and the PR.

krasserm commented 4 years ago

PR merged, thanks!