krasserm / grails-jaxrs

JAX-RS Plugin for Grails
http://code.google.com/p/grails-jaxrs/
Apache License 2.0
50 stars 48 forks source link

2.3.0 support? #30

Closed jdulude closed 10 years ago

jdulude commented 11 years ago

Current plugin does not work with 2.3.0. Are there plans for a new version? I love this plugin and would hate to have to abandon it. Thanks!

noamt commented 11 years ago

Yes. I'm currently working on a compatibility branch. I'll post on GH and the discussion group when some snapshots are ready

jdulude commented 11 years ago

Awesome, glad to hear. Thanks!

michaelrice commented 11 years ago

Also glad to hear this. We make HEAVY use of this plugin, thanks a lot for your efforts on it!

noamt commented 11 years ago

Yes. I'm currently working on a compatibility branch. I'll post on GH and the discussion group when some snapshots are ready On Sep 26, 2013 7:31 PM, "jdulude" notifications@github.com wrote:

Current plugin does not work with 2.3.0. Are there plans for a new version? I love this plugin and would hate to have to abandon it. Thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/krasserm/grails-jaxrs/issues/30 .

noamt commented 11 years ago

Please see my post here if you'd like to help my out by trying some snapshots of a Grails 2.3.x compatible version.

jdulude commented 11 years ago

Hi Noamt, thanks for all the work here. I've been doing some testing with your 0.10-snapshot and everything has worked great for me so far. I'll keep you posted if I find anything.

jdulude commented 11 years ago

What's the next step for getting this into the next official version of this plugin?

noamt commented 11 years ago

Well, I was going to wait on some more feedback, but nobody's complaining in the meantime so I guess we can release this.

jdulude commented 11 years ago

Great! Starting today I'll be having my QA department pounding on it a bit, so I'll let you know if anything comes up.

pherris commented 11 years ago

I am new to this project but using Grails 2.3.0. I'm pretty consistently getting this error:

| Error Fatal error during compilation org.apache.tools.ant.BuildException: java.lang.NoClassDefFoundError: org/springframework/beans/factory/Aware (Use --stacktrace to see the full trace)

BuildConfig.groovy

grails.servlet.version = "3.0" // Change depending on target container compliance (2.5 or 3.0)
grails.project.class.dir = "target/classes"
grails.project.test.class.dir = "target/test-classes"
grails.project.test.reports.dir = "target/test-reports"
grails.project.work.dir = "target/work"
grails.project.target.level = 1.6
grails.project.source.level = 1.6
//grails.project.war.file = "target/${appName}-${appVersion}.war"

grails.project.fork = [
// configure settings for compilation JVM, note that if you alter the Groovy version forked compilation is required
//  compile: [maxMemory: 256, minMemory: 64, debug: false, maxPerm: 256, daemon:true],

// configure settings for the test-app JVM, uses the daemon by default
test: [maxMemory: 768, minMemory: 64, debug: false, maxPerm: 256, daemon:true],
// configure settings for the run-app JVM
run: [maxMemory: 768, minMemory: 64, debug: false, maxPerm: 256, forkReserve:false],
// configure settings for the run-war JVM
war: [maxMemory: 768, minMemory: 64, debug: false, maxPerm: 256, forkReserve:false],
// configure settings for the Console UI JVM
console: [maxMemory: 768, minMemory: 64, debug: false, maxPerm: 256]
]

grails.project.dependency.resolver = "maven" // or ivy
grails.project.dependency.resolution = {
// inherit Grails' default dependencies
inherits("global") {
    // specify dependency exclusions here; for example, uncomment this to disable ehcache:
    // excludes 'ehcache'
}
log "error" // log level of Ivy resolver, either 'error', 'warn', 'info', 'debug' or 'verbose'
checksums true // Whether to verify checksums on resolve
legacyResolve false // whether to do a secondary resolve on plugin installation, not advised and here for backwards             compatibility

repositories {
    inherits true // Whether to inherit repository definitions from plugins

    grailsPlugins()
    grailsHome()
    mavenLocal()
    grailsCentral()
    mavenCentral()
    // uncomment these (or add new ones) to enable remote dependency resolution from public Maven repositories
    //mavenRepo "http://repository.codehaus.org"
    //mavenRepo "http://download.java.net/maven/2/"
    //mavenRepo "http://repository.jboss.com/maven2/"
    mavenRepo 'http://maven.restlet.org/'
    mavenRepo 'https://noams.artifactoryonline.com/noams/grails-jaxrs-plugin-snapshots'
}

dependencies {
    // specify dependencies here under either 'build', 'compile', 'runtime', 'test' or 'provided' scopes e.g.
    // runtime 'mysql:mysql-connector-java:5.1.24'
}

plugins {
    // plugins for the build system only
    build ":tomcat:7.0.42"

    // plugins for the compile step
    compile ":scaffolding:2.0.0"
    compile ':cache:1.1.1'

    // plugins needed at runtime but not for compilation
    runtime ":hibernate:3.6.10.1" // or ":hibernate4:4.1.11.1"
    runtime ":database-migration:1.3.5"
    runtime ":jquery:1.10.2"
    runtime ":resources:1.2"
    // Uncomment these (or add new ones) to enable additional resources capabilities
    //runtime ":zipped-resources:1.0.1"
    //runtime ":cached-resources:1.1"
    //runtime ":yui-minify-resources:0.1.5"
    compile ':jaxrs:0.10-SNAPSHOT'
    compile ":swagger4jaxrs:0.1"
    compile (':jaxrs:0.10-SNAPSHOT') {
        excludes 'spring-core', 'spring-beans', 'spring-context', 'spring-web', 'spring-aop'
    }
}
}
predicador37 commented 11 years ago

Hi, noamt:

I've downloaded your snapshot found here: https://groups.google.com/forum/#!topic/grails-jaxrs-discuss/KAiJW6Yhkv0

I've realized some test classes are missing (i.e.: org.grails.jaxrs.itest.IntegrationTestEnvironment).

Is there another way to obtain the 0.10 snapshot with all the necessary classes for testing?

Thanks in advance.

davidecavestro commented 11 years ago

I guess Noam is extracting spock support from the plugin in order to achieve better compatibility with newer versions of grails, see https://github.com/krasserm/grails-jaxrs/pull/33

predicador37 commented 11 years ago

OK, that's a great idea, definitely.

I'll leave the spock tests on stand by till there is a support plugin. Meanwhile, I hope I can try the snapshot myself and contribute with any possible issues (or no issues at all).

Thanks a lot!

pherris commented 11 years ago

I had a problem in my BuildConfig.groovy

compile ':jaxrs:0.10-SNAPSHOT' //SHOULD NOT HAVE HAD THIS LINE
compile ":swagger4jaxrs:0.1"
compile (':jaxrs:0.10-SNAPSHOT') {
    excludes 'spring-core', 'spring-beans', 'spring-context', 'spring-web', 'spring-aop'
}

updating per the below link worked:

https://groups.google.com/forum/#!topic/grails-jaxrs-discuss/KAiJW6Yhkv0

davidecavestro commented 11 years ago

The snapshot is a work in progress. Could you please give us more details on the problem you had?

noamt commented 11 years ago

I think the issue was the double dependency declaration of the jax-rs plugin. One declared with exclusions and the other without

On Tue, Oct 22, 2013 at 9:34 AM, Davide Cavestro notifications@github.comwrote:

The snapshot is a work in progress. Could you please give us more details on the problem you had?

— Reply to this email directly or view it on GitHubhttps://github.com/krasserm/grails-jaxrs/issues/30#issuecomment-26780199 .

nicholashahn commented 11 years ago

I just wanted to chime in that I have been using the 0.10-SNAPSHOT for about 2 weeks on Grails 2.3.0, and everything is working great.

pherris commented 11 years ago

@noamt is right, the double declaration was the issue.

jdulude commented 10 years ago

Any plans of making the 2.3 branch an official version?

noamt commented 10 years ago

Yes, It'll be ready soon; I've been on vacation the past few weeks

jdulude commented 10 years ago

Great, thanks for the response. Hope you had an awesome vaca!

noamt commented 10 years ago

Closing with the release of 0.10 https://github.com/krasserm/grails-jaxrs/wiki/Release-notes-for-grails-jaxrs-version-0.10