search

krasserm / streamz

A combinator library for integrating Functional Streams for Scala (FS2), Akka Streams and Apache Camel
Apache License 2.0
282 stars 44 forks source link

Generalize fs2<->akka compat to F: Effect instead of IO #47

Closed Daenyth closed 6 years ago

Daenyth commented 6 years ago

I'd like to use streamz-converter with any Effect instead of just IO.

I glanced at the code and haven't spotted anywhere that this would be difficult, though I could have missed it of course.

If this change is acceptable I might submit a PR for it.

Daenyth commented 6 years ago

I looked more closely and I didn't see any blockers.

Given implicit F: Effect[F] added to the method arguments;

IO.apply -> F.delay IO.shift -> Timer[F].shift IO.pure -> F.pure IO.async -> F.async

krasserm commented 6 years ago

Did you see #46 ?

krasserm commented 6 years ago

Closing as duplicate of #46. Your feedback on that PR is welcome!