Upgrade to cats-effect 2.x, preliminary scala 2.13 support

krasserm / streamz

A combinator library for integrating Functional Streams for Scala (FS2), Akka Streams and Apache Camel

Apache License 2.0

282 stars 44 forks source link

Upgrade to cats-effect 2.x, preliminary scala 2.13 support #63

Closed Daenyth closed 5 years ago

Daenyth commented 5 years ago

Upgrade to cats-effect 2.x, fs2 1.1.x
Add api to avoid dropping Future[Mat] values
Deprecate apis hardcoding IO
Fix race condition in akka-fs2 publisherStream between interruption and publish when using the fromFuture+ContextShift.shift behavior
Test changes to make wording match assertions better
Add scala-collection-compat for camel converter crossbuilding
Bump version for milestone release
Include sbt-tpolecat plugin to prevent lintable bugs

Ref #61 Close #62

Daenyth commented 5 years ago

I did reproduce the test failures; One oddity is that I've seen one pass when run in isolation from the other tests. I expect it's some kind of race condition due to the cs.shift from FromFuture now.

Both failing tests involve publisherStream

krasserm commented 5 years ago

To get rid of the Oracle JDK 8 related error message on Travis CI please rebase on master. See also https://github.com/krasserm/streamz/commit/2a17e813554379a8b51c14f0a0699ea32e4d0ffa

Daenyth commented 5 years ago

I figured out the test failures - it's a race condition in publisherStream between interruptWhen and publish.

I also backported the workaround for #54 - the test description didn't match what the test was actually doing. Now it does.

There's api changes that address #62