search

krassowski / Anki-TouchScreen

Touchscreen functionality for Anki
https://ankiweb.net/shared/info/1631622775
GNU General Public License v3.0
25 stars 13 forks source link

changed emojis to text in buttons #20

Closed Reyuu closed 4 years ago

Reyuu commented 4 years ago

Emojis were causing display problems. Replaced them with text.

krassowski commented 4 years ago

What kind of problem where they causing?

Reyuu commented 4 years ago

@krassowski They weren't displaying correctly image

Text would be the best, platform agnostic option in this case imo, which is why I suggested this PR.

krassowski commented 4 years ago

Looks like a font-size issue and I think it should be fixed by setting the font size on the glyphs. I appreciate your effort but I am sure that there would be users who will consider the larger buttons with text rather than icons to be a step backwards; also, not everyone is speaking English and ideally, you should also provide translations to all the languages that Anki support (the add-on being documented in English does not mean that the basic functionality is not used by non-English speakers).

Reyuu commented 4 years ago

Ah I somehow missed it in my reasoning. Sorry about it.

Let's close this PR then.