search

krassowski / jupyter-manim

manim cell magic for IPython/Jupyter to show the output video
MIT License
194 stars 11 forks source link

Allow output as gif #17

Closed NickLarsenNZ closed 4 years ago

NickLarsenNZ commented 4 years ago

Hi, I really like this project!

It would be great if %%manim allowed output as GIF, so that when notebooks are being rendered in Github, the animations can be seen.

GIF is available in manim: https://github.com/3b1b/manim/pull/529/files

An example of where I'm trying to see it: https://github.com/NickLarsenNZ/notebooks/blob/650a92ef9611d5e70cee4cfff943b2b6cfc6408d/math/manim-walkthrough.ipynb (I've tried both default (mp4) and base64 video .output)

krassowski commented 4 years ago

Thank you for opening this issue. You are right! I have just implemented the support for gifs. Please have a try with 1.2 version.

NickLarsenNZ commented 4 years ago

Brilliant, thank you.

Just noticed the latest commit introducing gif support isn't yet tagged.

krassowski commented 4 years ago

Do you mean GitHub release tag?

On Mon, 6 Apr 2020 at 10:50, Nick notifications@github.com wrote:

Brilliant, thank you.

Just noticed the latest commit introducing gif support isn't yet tagged.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/krassowski/jupyter-manim/issues/17#issuecomment-609692474, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMQBRQBCSK242TF3MXOQ53RLGQXDANCNFSM4MAWVWRA .

-- Best regards, Michał Krassowski

NickLarsenNZ commented 4 years ago

Yeah the git tag. I also noticed the Readme doesn't mention the new options (-i and --save_as_gif).

If I get a chance tomorrow, I'm happy to raise a PR.