search

krassowski / jupyter-manim

manim cell magic for IPython/Jupyter to show the output video
MIT License
194 stars 11 forks source link

Add looping video option, as proposed in #20 #21

Closed remisphere closed 4 years ago

remisphere commented 4 years ago

Hello again, Here is a PR for the issue I opened yesterday for the video looping. This is my first PR ever, I am sorry if I missed anything.

I set looping as default, it is debatable I guess.

krassowski commented 4 years ago

This looks great, thank you for preparing it. I see arguments both for and against having looping as a default - I will merge as is and possibly change it later.

krassowski commented 4 years ago

@Scoder12 would you have a preference on having looping as a default?

Scoder12 commented 4 years ago

Yeah, I think it should be off by default