search

krassowski / jupyter-manim

manim cell magic for IPython/Jupyter to show the output video
MIT License
194 stars 11 forks source link

Add remote option #6

Closed Scoder12 closed 4 years ago

Scoder12 commented 4 years ago

Adds a --remote option which sends the video with a data:video/mp4;base64, URL instead of a relative path. This is useful for when you are working on a remote machine like Google Colab and don't have access to the filesystem. The data: URL sends the entire base64 encoded file in the src of the video HTML if the --remote option is passed to the cell magic. I have tested this on Google Colab and it works like a charm. Would love to see this pushed so I can shorten by setup cell to just an import rather that all this code. Appreciate this library!

krassowski commented 4 years ago

Thank you, this is a great idea! I'm just not sure about the reassignment of -r - this could break the code of some existing users. How would you feel about using another shorthand?

Scoder12 commented 4 years ago

@krassowski Yeah I realized that after my first commit and changed it from -r and --remote to only --remote once I realized that in 20acb22

Scoder12 commented 4 years ago

How about now? If you have anything specific in mind I honestly don't care what the name is.

krassowski commented 4 years ago

Great! Thank you for you contribution. I will look into #5 and release a new version then.

Scoder12 commented 4 years ago

Oops, forgot to change the README. It still says --remote