krateng / maloja

Self-hosted music scrobble database to create personal listening statistics and charts
https://maloja.krateng.ch
GNU General Public License v3.0
1.18k stars 69 forks source link

Misc. fixes from first use #328

Closed ThinkChaos closed 6 months ago

ThinkChaos commented 9 months ago

Hi,

Thanks for creating this it's pretty cool! Here's a couple fixes I did when getting it to work for me. I have a bit of an unusual setup: I use NixOS and manage my config in Nix files, which then generate the config for the app. That generated config is in a read-only filesystem. It sounds weird at first, but it has a lot of advantages which is not the point here, so I won't say any more.

I have to say my first time setup was quite rough, so here's some constructive feedback:

I went with minimal changes, but TBH after spending a lot of time looking at the code I'm under the impression it would need a lot of reworking. There's a lot of custom code (which is fun to do, and I totally understand the want), but I think the consequence is everything is not as polished as it could be if you relied more on standard/library solutions.
The INI thing is a good example of that IMO. But even more generally, rolling your custom crypto, custom config code, etc. ends up adding a lot of bugs where the python ecosystem already has great solutions :)

I hope this doesn't sound too harsh, I really appreciate all the work you've done, and the UX is most likely a lot better using the container. Just trying to give constructive criticism and feedback.

ThinkChaos commented 9 months ago

Just for reference, I also opened https://github.com/krateng/doreah/pull/3 with related changes.