kratzert / Caravan

A global community dataset for large-sample hydrology
BSD 3-Clause "New" or "Revised" License
174 stars 34 forks source link

Add name check for basin id field #8

Closed kratzert closed 2 years ago

kratzert commented 2 years ago

See #7, the problem was that the intersected polygons contains the fields/values of both shapefiles. In this case, the basin id field was present in the user shape file but also HydroATLAS (HYBAS_ID). This led to the problem that one intersected polygon had a HYBAS_ID that is not part of the basin_ids list (which only contains the basins between the thresholds).

In this PR I am adding a check that makes sure that the user specified BASIN_ID_FIELD is different to any HydroATLAS field.

kratzert commented 2 years ago

Also update the Wiki to include this information.