search

krauskopf / node-red-contrib-car-bmw

Node-RED nodes for BMW ConnectedDrive
Other
11 stars 8 forks source link

fix: issue #22 - send post parameters in request URL in addition #23

Closed amuehlhause closed 1 year ago

amuehlhause commented 1 year ago

I've added the post parameters to the query string as this fixed the concrete service action to be triggered.

Before "climate-now" always triggered the climate service to be started and never to be stopped (as the concrete action was ignored and the default is to start the climate service).

That said the post parameter "action=STOP" was always ignored as it seems to be not enough to submit it via https post request body. I've added it to the request URL as query string which fixed the issue.

The query string seems to be enough and the request body seem to be not necessary. However I let it in for compatibility reason. Also, I never was able to fix the issue by only using the request body (even with application/x-www-form-urlencoded content type). Maybe specs have changed, so the action parameters need to be part of the request URL?

krauskopf commented 1 year ago

Thanks @amuehlhause for the PR.