search

krauthaufen / Adaptify

MIT License
38 stars 3 forks source link

1.1.6 silently requires FSharp.Core 6.0 #30

Open haraldsteinlechner opened 2 years ago

haraldsteinlechner commented 2 years ago

manifests in apps using F# 5.0.. seealso https://github.com/aardvark-platform/aardvark.base/issues/79

haraldsteinlechner commented 2 years ago

what to do here? where is 1.1.6 btw? there seems to be no tag? https://github.com/krauthaufen/Adaptify/tags

krauthaufen commented 2 years ago

The msbuild integration and the tool actually require FSharp.Core 6.0 (caused by the compiler services most likely) but the runtime part should not. I guess nuget/paket can't handle that properly since the msbuild task isn't really a runtime dependency and could therefore use a different FSharp.Core version. I guess the only feasible way to solve this is actually requiring 6.0 in adaptify

haraldsteinlechner commented 2 years ago

i'm checking on this. please push the tag if possible (or is it in another branch?) image

krauthaufen commented 2 years ago

The thing is CI built

krauthaufen commented 2 years ago

So i don't have any local tags, maybe something with the CI is wrong, but you can just lookup the Release-Notes history to find the appropriate commit

haraldsteinlechner commented 2 years ago

i put adaptify.core deps into a separate group - https://github.com/krauthaufen/Adaptify/issues/30 this looks promising, but i could not test it properly since using the example sln after running build merge constantly tries to install adaptify as tool 0.0.0.0 which fails. What was the local testing procedure? Running a server side-by-side also does not work - it seems like the decision whether something needs to be installed does not work for me any longer ?!

krauthaufen commented 2 years ago

Testing things locally was pretty painful, you need to pin the version somewhere in the code and start a server manually, etc.

krauthaufen commented 2 years ago

fixed in 1.1.8

haraldsteinlechner commented 8 months ago

i think this problem was fixed here again: https://github.com/krauthaufen/Adaptify/commit/e7797b4625e3b3d030b93a1729a1f540e164f310

What puzzles me here is "hans" being part of the source path - is this strange? https://github.com/krauthaufen/Adaptify/commit/e7797b4625e3b3d030b93a1729a1f540e164f310#diff-5ebd60ceb88910043c04c5a665d836197d7184488edcf52f590e8fcad6101519R291