search

krautzource / aria-tree-walker

A lightweight walker for labeled ARIA trees
https://krautzource.github.io/aria-tree-walker/
Apache License 2.0
2 stars 0 forks source link

abstractTree: recurseNodeToExtractTree should work off the root #33

Closed pkra closed 3 years ago

pkra commented 3 years ago

recurseNodeToExtractTree searches for data-owns-id below the current node. It should look inside the root (to avoid failure in aria-owns-like situations).

pkra commented 3 years ago

recurseNodeToExtractTree searches for data-owns-id below the current node. It should look inside the root (to avoid failure in aria-owns-like situations).

I think the source of the problem might be different. We do search widely, but too widely - across the entire document

https://github.com/krautzource/aria-tree-walker/blob/fc35c85c1302df4256ac45af43000b3149404db8/lib/abstractTree.js#L32

We should search the treebase instead.

pkra commented 3 years ago

This is a really dumb bug and due to #25 since we used to have proper/unique IDs.