search

krautzource / sre-to-tree

MIT License
0 stars 0 forks source link

re-evaluate non-tree roles #13

Closed pkra closed 3 years ago

pkra commented 3 years ago

In particular, do we have working links?

pkra commented 3 years ago

In particular, do we have working links?

Not really. MathJax treats anchors poorly and it seems difficult to fix this here. We'd also need activation logic in aria-tree-walker. And then there's the issue of the achor being in the tab order. Yikes, this is a mess.

pkra commented 3 years ago

In https://w3c.github.io/aria-practices/examples/treeview/treeview-navigation.html, anchors role=treeitem and tabindex=-1 - JS then adds keyDown events for enter and space to follow the link.

Now we only have to fix the SRE/MathJax markup.

pkra commented 3 years ago

As per F2F, @zorkow will take a look at how SRE might expose links.

pkra commented 3 years ago

After more digging around and testing I think we can remove

https://github.com/krautzource/sre-to-tree/blob/90391d288abacd5bb2c73b12b856be907b5053f1/lib.js#L31-L36

a) anchor tags can and should be treeitems b) image tags might as well be treeitems - we unintentionally set them to role=presentation later via https://github.com/krautzource/sre-to-tree/blob/90391d288abacd5bb2c73b12b856be907b5053f1/lib.js#L152-L154 (and we forgot about img tags) c) if we find a use case for a role that should not be rewritten, we can revisit preserving those; right now we don't have a use case.

pkra commented 3 years ago

For the record, tabindex=-1 should be set upon tree activation (as progressive enhancement, e.g., https://github.com/krautzource/aria-tree-walker/issues/22).