krautzource / sre-to-tree

MIT License
0 stars 0 forks source link

unexpected/invalid role=presentation #28

Closed pkra closed 2 years ago

pkra commented 2 years ago

Some examples

These cases create some nodes without speech or braille but tree markup ending up with something like data-owns-id="12" aria-level="5" aria-posinset="3" aria-setsize="3" role="presentation" (which leads to validation errors since presentation does not support these attributes).

At least some of the cases seem connected to invisible times.

pkra commented 2 years ago

As an aside: svg-aam does not permit any roles on defs elements (so we should not set role to presentation).

pkra commented 2 years ago

The case of $\rho \mapsto (0\oplus 0 \oplus \rho )$ seems to be ok with SRE v4.

pkra commented 2 years ago

Gnarly https://github.com/Speech-Rule-Engine/speech-rule-engine/issues/633

pkra commented 2 years ago

Some movement upstream https://github.com/Speech-Rule-Engine/speech-rule-engine/pull/648

pkra commented 2 years ago

Fix solves the most problematic part but still seems weird.

pkra commented 2 years ago

Ok, the highlighting issue is my fault -- my demo wasn't styling the new .is-highlight class that aria-tree-walker uses.

It's still not great because SRE creates slightly weird markup (see my comment on the issue) which means the outline won't extend to all children. But that's a general problem.

pkra commented 2 years ago

Closing as essentially fixed.