search

krautzource / sre-to-tree

MIT License
0 stars 0 forks source link

root should not have aria-level #30

Closed pkra closed 2 years ago

pkra commented 2 years ago

During some refactoring, we decided to run rewriteNode on the root node. But

https://github.com/krautzource/sre-to-tree/blob/d468b06ef829750ea8baa4fa19b6452e07216e77/lib.js#L33-L41

adds aria-level -- which tree roots should not have. (Which in turn increases the level of all children.)

pkra commented 2 years ago

Apparently not an accident:

https://github.com/krautzource/sre-to-tree/blob/d468b06ef829750ea8baa4fa19b6452e07216e77/test/positioning.js#L11

I simply messed up :frowning:

pkra commented 2 years ago

Hm.. This fix leads to a regression downstream affecting Firefox (across orca, nvda, jaws). Needs more investigation.

pkra commented 2 years ago

Second time around I have the same mess of problems. But I'm also a bit flummoxed by how the APG patterns work with NVDA and JAWS.

pkra commented 2 years ago

Well, it would help to remember to upgrade the tree walker in my demo setup to 3.4.0 (which adapted to #27).

No wonder nothing worked...