pam_tacplus: incorrect args parsing

kravietz / pam_tacplus

TACACS+ protocol client library and PAM module in C. This PAM module support authentication, authorization (account management) and accounting (session management)performed using TACACS+ protocol designed by Cisco.

GNU Lesser General Public License v3.0

132 stars 100 forks source link

pam_tacplus: incorrect args parsing #125

Closed vmwalex closed 5 years ago

vmwalex commented 5 years ago

support.c@306: for(i = tac_srv_no-1; i != 0; i--) {

pam_tacplus secret=123 server=1.1.1.1: tac_srv_no-1 == 0-1 == MAX_UINT -> segfault pam_tacplus server=1.1.1.1 secret=123: tac_srv_no-1 == 1-1 == 0 -> secret is not set for srv[0]