kravietz / pam_tacplus

TACACS+ protocol client library and PAM module in C. This PAM module support authentication, authorization (account management) and accounting (session management)performed using TACACS+ protocol designed by Cisco.
GNU Lesser General Public License v3.0
132 stars 102 forks source link

Use '%zd' and '%zu' as ssize_t and size_t formatters #136

Closed casantos closed 4 years ago

casantos commented 4 years ago

Fixes build error with GCC 8.3.0, for nios2:

In file included from libtac/lib/magic.h:24, from libtac/lib/magic.c:35: libtac/lib/magic.c: In function ‘magic’: libtac/lib/magic.c:77:25: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘ssize_t’ {aka ‘int’} [-Werror=format=] TACSYSLOG(LOG_CRIT,"%s: getrandom less bytes than expected: %ld vs %lu", FUNCTION, ret, sizeof(num)); ^~~~~~~~~~~~ ~~~ ./libtac/include/libtac.h:70:50: note: in definition of macro ‘TACSYSLOG’

define TACSYSLOG(level, fmt, ...) syslog(level, fmt, ## __VA_ARGS__)

                                              ^~~

libtac/lib/magic.c:77:25: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘unsigned int’ [-Werror=format=] TACSYSLOG(LOG_CRIT,"%s: getrandom less bytes than expected: %ld vs %lu", FUNCTION, ret, sizeof(num)); ^~~~~~~~~~~~ ~~~ ./libtac/include/libtac.h:70:50: note: in definition of macro ‘TACSYSLOG’

define TACSYSLOG(level, fmt, ...) syslog(level, fmt, ## __VA_ARGS__)

                                              ^~~

cc1: all warnings being treated as errors

Signed-off-by: Carlos Santos unixmania@gmail.com

casantos commented 4 years ago

On Sat, Jan 11, 2020 at 2:26 PM Philip Prindeville notifications@github.com wrote:

Merged #136 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks. Do you know when a version containing the latest fixes will be released? We have been stuck at v1.5.0-beta.2 for almost two years.

-- Carlos Santos unixmania@gmail.com