search

kraxarn / spotify-qt

Lightweight Spotify client using Qt
GNU General Public License v3.0
1.1k stars 63 forks source link

spotify-qt crashes when no playlists are found #17

Closed mikedebian closed 4 years ago

mikedebian commented 4 years ago

Was told to post the issue here from the haiku forums.

Here is the relevant pastebin

https://pastebin.com/2BNDZS2J

Segmentation fault.

I don't know if this is something you're willing to do anything about, but posting it anyway. Help appreciated :)

https://discuss.haiku-os.org/t/tip-how-to-get-spotify-qt-running/9746/11

Begasus commented 4 years ago

@mikedebian was this on 64bit? I have the same issue on 32bit Haiku

mikedebian commented 4 years ago

@Begasus This is x86_64 (64-bit).

Interesting to know that it's not because of x86_64, thanks! :)

kraxarn commented 4 years ago

I'm not too familiar with Haiku, but someone did get it working without modification in #16. I could also set up an environment to check for myself and see if I can reproduce it.

kraxarn commented 4 years ago

I'm not able to reproduce the issue, as it seems to work just fine in my virtual environment with an updated version of Haiku. You can try running cmake with cmake -DCMAKE_BUILD_TYPE=Debug .. and then run the application through gdb to see if you get any helpful output from there.

Begasus commented 4 years ago

I don't have a premium account at spotify, not sure if others that don't have it also suffers from this, but will check a build with Debug enabled

mikedebian commented 4 years ago

I have premium, no freemium. Read from others that it does not matter.

kraxarn commented 4 years ago

Possibly fixed in d3542a4c4a5185331e6638a0ee0633c016a67788, as one of the possible causes was that no playlists were found to load. Please either wait for the next release or compile from source to see if the issue is resolved.

Begasus commented 4 years ago

Seems to be fixed!

Spotify-Qt

Begasus commented 4 years ago

Merged a source checkout at haikuports for this at https://github.com/haikuports/haikuports/pull/5179

mikedebian commented 4 years ago

Fixed in newest revision.

kraxarn commented 4 years ago

Great. Then it should probably just handle it a bit better before closing the issue.

Begasus commented 4 years ago

As mentioned in the forum by @mikedebian it probably needs spotifyd to be able to load the playlists?

kraxarn commented 4 years ago

spotifyd is only used for music playback, playlist are fetched directly from the Spotify API. The only integration with spotifyd is that it can be configured from within the app, but it's not required. If you have playlists and they aren't showing in the application, that's a separate issue.

Begasus commented 4 years ago

Ok, then for Haiku it seems to be ok and a seperate issue for not loading the playlist should be created, thanks for clarification!