krayin / laravel-crm

Free & Opensource Laravel CRM solution for SMEs and Enterprises for complete customer lifecycle management.
https://krayincrm.com
Open Software License 3.0
11.13k stars 752 forks source link

The filter label should be visible if the admin is trying to filter the attributes. #1087

Closed Sanjaybhattwebkul closed 2 years ago

Sanjaybhattwebkul commented 2 years ago

Bagisto Version: Master

Steps To reproduce--

1. Log in as an admin. 2. Click on attributes inside the setting, 3. Try to filter the attributes.

Expected result: The filter label should be visible if the admin is trying to filter the attributes.

Actual result: The filter label is not visible if the admin is trying to filter the attributes. Please find the screenshot Here

prabhat-webkul commented 2 years ago

https://github.com/krayin/laravel-crm/blob/dc0d9ffa92fd060c22ddfa7e88be0a330db8b16a/packages/Webkul/UI/src/Resources/assets/js/components/datagrid/filters.vue#L205

This line of code is just used for displaying labels, and if it will not find any string under datagrid.filter of string file https://github.com/krayin/laravel-crm/blob/master/packages/Webkul/UI/src/Resources/lang/en/app.php then it will show blank.

If a URL query string is ?scheduled[eq]=yesterday&type[eq]=meeting then need to translate "scheduled" and "type" to show the label into multi-language.

prabhat-webkul commented 2 years ago

https://github.com/krayin/laravel-crm/blob/dc0d9ffa92fd060c22ddfa7e88be0a330db8b16a/packages/Webkul/UI/src/Resources/assets/js/components/datagrid/filters.vue#L205

This line of code is just used for displaying labels, and if it will not find any string under datagrid.filter of string file https://github.com/krayin/laravel-crm/blob/master/packages/Webkul/UI/src/Resources/lang/en/app.php then it will show blank.

If a URL query string is ?scheduled[eq]=yesterday&type[eq]=meeting then need to translate "scheduled" and "type" to show the label into multi-language.

applied changes to display label also when string is not translated #1089