search

krayin / laravel-crm

Free & Opensource Laravel CRM solution for SMEs and Enterprises for complete customer lifecycle management.
https://krayincrm.com
MIT License
7.52k stars 499 forks source link

When we create a web form and create a persons from here so in contact phone no. field is not taking validation, here added with letters also #1239

Closed komal-sh-27 closed 2 weeks ago

komal-sh-27 commented 3 months ago

Title:

When we create a web form and create a persons from here so in contact phone no. field is not taking validation, here added with letters also

Steps to Reproduce:

Step 1: Create a web form under settings option like this:

image

image

Step 2: Now create a persons from this web form with contact form add text instead of numbers:

image

image

Step 3: Now go to the admin panel under contacts -> persons option, here shows a text in phone no. coloumn:

image

Expected result:

If we have enter a text in phone no field then should be shown a warning like this:

The Contact Numbers field may only contain numeric characters

image

Actual result:

If we have added a text or characters in phone no field then web form submit without any warning shows.

prabhat-webkul commented 2 months ago

PR https://github.com/krayin/laravel-crm/pull/1245

harshit-webkul commented 2 months ago

In web form page, The contact number field should only accept numeric values, and a validation message should appear if an alphanumeric or character value is entered.

Attached video/screenshot reference

https://github.com/krayin/laravel-crm/assets/163374765/c1a3699c-26f6-43f1-8bae-d067f2025165

prabhat-webkul commented 2 months ago

because basic validation is added for now as no custom js is used,

not planning currently, create a separate issue as enhancement/feature