krazkidd / kdeck

Desktop client for Kalshi event trading platform
GNU General Public License v3.0
2 stars 0 forks source link

Add `v` prefix to git version tags? #71

Open krazkidd opened 1 month ago

krazkidd commented 1 month ago

Apparently there is a convention for prefixing git version number tags with the letter v. At one time, this was even recommended in the semver spec but the latest version clarifies that it is only a convention and is not even a valid semver.

This project originally used the v prefix but dropped the prefix because GitHub workflows don't provide easy string manipulation and we use the tag itself as the app version in builds. I think the v is preferable as it enhances discoverability. But it would require a refactor of the GitHub release workflow(s).

krazkidd commented 1 month ago

Some non-definitive discussions around this: