Closed ImperatorTheo closed 5 years ago
Just noticed this, was out of town all last month. Will check it out.
Hm, the variable AcceptLoserAmount does not store just ture or false. But also the name of the loser. Thus we would save ourselves a variable.
You are welcome to change that, if you want. I find that hard to adjust because my develop branch unfortunately is already on. Had made a mistake with git and do not know how to solve this best now.
For me, I added the following features:
Maybe you could change that in general later. As far as I know are also other variables because you would then have to adjust. Would possibly be a cleanup what you could tackle if it is gemerged?
Or does that not affect these variables as well?
AcceptOnes = "false";
local AcceptRolls = "false";
Hm, the variable AcceptLoserAmount does not store just ture or false. But also the name of the loser. Thus we would save ourselves a variable.
Right. In Lua, for if statements, anything that is not nil, or false is true. So this would still work in this case. Since you're storing "false" or a name, this would work just fine.
As for your git issues, I'll try to find some time to make the changes I want for you and get it in. Everything else looks ok.
I can't push my changes. Do you have an option on the right side of this screen to allow to me push changes to the branch?
Are Features from https://www.curseforge.com/wow/addons/wanderers-gambling i just adapted that I think I fit well in the code.