krbaker / hass-sunpower

Home Assistant SunPower Integration using the local installer ethernet interface.
Apache License 2.0
49 stars 22 forks source link

Addresses Issues #40 #41

Closed heyhewmike closed 1 year ago

heyhewmike commented 1 year ago

The 'StateClass*' has been updated for "Meter_to_Grid" & "Meter_net_KWH" to allow for negative values. Changed from 'STATE_CLASS_TOTAL_INCREASING' to 'STATE_CLASS_TOTAL'.

Correction for - lifetime_power from integration sunpower has state class total_increasing, but its state is negative.

I have run this updated code on my test instance for 48 hours without issue, with several HS Restarts & atleast 1 HA Upgrade (2023-2-3 to 2023-2-4 most recently) and still running the updated code.

heyhewmike commented 1 year ago

Hi,

I made the change in the Readme so that nobody tried to use my repo and get any bad code. This is my first ever real Pull Request and did not realize that was included.

heyhewmike commented 1 year ago

Do to my beginner experience I tried to edit this to delete the file that requires changes and somehow it appears to have created Pull Request 43,

heyhewmike commented 1 year ago

Due to Main being a Protected Branch this is superseded PR 43.