krbcontext / python-krbcontext

A Kerberos context manager
https://krbcontext.github.io/
GNU General Public License v3.0
25 stars 10 forks source link

Fix renewing expired FILE ccache #24

Closed msimacek closed 5 years ago

msimacek commented 5 years ago

Renewing expired FILE ccache didn't work because krbcontext created an empty file for the ccache, but kerberos considered an empty file invalid.

Fix this by creating a temporary directory and letting kerberos create the ccache file by itself (which is a perfectly valid scenario). Also add cleanup for the temporary dir and fix the directory naming.

Fixes #23

codecov-io commented 5 years ago

Codecov Report

Merging #24 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #24   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         110    109    -1     
=====================================
- Hits          110    109    -1
Impacted Files Coverage Δ
krbcontext/context.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9dc9376...24d5baa. Read the comment docs.

tkdchen commented 5 years ago

Thank you very much.

msimacek commented 5 years ago

Would you mind making a new release?

tkdchen commented 5 years ago

Hi @msimacek, I'm preparing a new release. It'll be available soon. BTW, from where do you install krbcontext, PyPI or some Linux distro package repositories like Fedora repos? Generally, a new release is published to PyPI. If you are expecting krbcontext is installable from Linux package repositories, I can build the package as well. Currently, it is in Fedora and EPEL repos.

msimacek commented 5 years ago

We were previously building our own RPMS from the release tarball, but soon we'll switch to using PyPI. Thank you

tkdchen commented 5 years ago

@msimacek Hi, new release is avaialble in PyPI already.