krbz999 / babonus

Other
18 stars 10 forks source link

[BUG] Optional damage bonuses can cause the Configure Roll window to partially appear offscreen #478

Open etiquettestartshere opened 1 month ago

etiquettestartshere commented 1 month ago

Describe the bug

To Reproduce

  1. Create an item with a damage activity.
  2. Add an optional damage bonus bab.
  3. Fill your chatlog with backscroll, then use the damage activity so that the damage button appears near the bottom of the chatlog.
  4. Click "damage", and see the roll config, and it will appear partway off the bottom of the screen.

Expected behavior The window appears with its bottom edge aligned with the bottom of foundry's max resolution

Screenshots image

Setup Describe your foundry setup.

Additional Considerations Though the above screenshot was taken on my usual font size 6, I confirmed I got the same result on font size 5. No idea what the solution here is as the Roll Configuration is a moving target with its position based on the damage button

krbz999 commented 1 month ago

Not technically a bug but a weirdness with how injecting html elements onto an existing application works. But there might be something that can be done on the module end.