krbz999 / visual-active-effects

MIT License
2 stars 8 forks source link

Module incompatibility with css of content links #56

Closed kristianserrano closed 9 months ago

kristianserrano commented 9 months ago

The black color of content links against the dark background in the effect descriptions makes the links difficult to read. I think using the navajowhite that's used in the heading for the color of the links works well.

krbz999 commented 9 months ago

image

I am not seeing what you are seeing.

kristianserrano commented 9 months ago

This is what I'm seeing.

Screenshot 2024-01-20 at 4 36 07 PM

And this is the CSS being applied.

section.visual-active-effects .effect-item .effect-info .effect-info-details .inline-roll, section.visual-active-effects .effect-item .effect-info .effect-info-details .content-link {
    color: black;
}
krbz999 commented 9 months ago

And you tested this in what system, and presumably with only VAE active?

kristianserrano commented 9 months ago

It's in the SWADE system, and not with modules disabled. But that CSS selector in the visual effects CSS file is applying a black color to .content-link regardless.

krbz999 commented 9 months ago

image

This image is taken using only VAE, with SWADE v3.2.5.

kristianserrano commented 9 months ago

I understand. This is content being pulled from a content module over which I have no control. Regardless, VAE's CSS is applying a black color to the .content-link class in the module's CSS. Is that style definition addressing a specific need?

krbz999 commented 9 months ago

The text in effect descriptions is set to a brighter color to be readable on the dark background. This also affects the content links, so the black was meant to reset this.

Testing in both swade and dnd5e, using color: initial; instead does the same trick. I'm prepared to make that change if that solves it for you. You can test it yourself in the console.

kristianserrano commented 9 months ago

Setting it to initial seems to bring it back to #ddd as defined in the definition for the selector section.visual-active-effects .effect-item .effect-info .effect-info-details :is(.effect-intro, .collapsible-content, .vae-buttons). Using revert brings it to the same color as the text it seems.

If it's too much trouble to resolve, I'm fine with just overriding it with the rest of my custom styles using the Custom CSS module.

krbz999 commented 9 months ago

I don't know what module it is you are using, so I cannot test the interaction myself. Where you should be testing it is by editing the css of VAE. I.e., change it from color: black to color: initial, not adding a new style.

kristianserrano commented 9 months ago

I didn't add a new style. I edited the definition in your file via dev tools.

krbz999 commented 9 months ago

Then I am afraid I have no solution. I cannot conditionally apply css depending on whether a module is removing the default border and background of content links.

kristianserrano commented 9 months ago

It's fine. Like I said, I can inject custom CSS myself.