search

kreait / firebase-bundle

A Symfony Bundle for the Firebase PHP Admin SDK
https://github.com/kreait/firebase-php
MIT License
135 stars 25 forks source link

Make verifier cache configurable #19

Closed jeromegamez closed 4 years ago

jeromegamez commented 4 years ago

An alternative approach to #18

Makes the verifier cache (used to cache Google's Public Keys for ID token verification, see documentation)) configurable.

It's not pretty, but it's knowing that the bundle will be rewritten from scratch for a 2.0 release 🙈

:octocat:

Orkin commented 4 years ago

Hi, yes I think it can do the job too. It's not pretty but I prefer your solution than mine 😅. I'm not really fan about non immutable object but you're right, for now I think this bundle need a big rewrite to allow more configuration customization.

The best will be to do something like with doctrine cache with the ability to provide a service id or a class that will be instanciate only for this purpose.

It's ok for me, you can close #18 and merge this one.

jeromegamez commented 4 years ago

Here it is: https://github.com/kreait/firebase-bundle/releases/tag/1.8.0 🎉