search

kreait / firebase-bundle

A Symfony Bundle for the Firebase PHP Admin SDK
https://github.com/kreait/firebase-php
MIT License
135 stars 25 forks source link

Add configuration option tenant_id to make the client tenant aware #31

Closed eriwin closed 3 years ago

eriwin commented 3 years ago

You can now set the tenant_id in the config to make the client tenant aware.

Example:

kreait_firebase:
  projects:
    myproject:
      tenant_id: 'test-fmo4p'

I also updated the README.md and added a unit test. It would be great if this is something you would like to add to the bundle. Let me know if I can do anything else for this pull request.

jeromegamez commented 3 years ago

Thank you, Erik 🌺! From my mobile phone this looks perfect, I'll have a finishing look and merge it as soon as I'm back at my computer 💪!

eriwin commented 3 years ago

Thank you for your quick reply. I do see the Travis-ci pipelines failing but it does not seem related to the changes I made?

jeromegamez commented 3 years ago

No, they are broken since forever, but that's not related to the code, of course, I just didn't manage to migrate them to GitHub Actions yet 🙈

eriwin commented 3 years ago

I understand. Good to know 😄

jeromegamez commented 3 years ago

Well, that's embarrassing... it was me who broke the tests a couple of weeks ago when I changed something in the underlying SDK, but 🤫🤫🤫. It will be broken in a couple of weeks when travis-ci.org shuts down, but it will not be because of the code at least 😅.

Long story short: merged with https://github.com/kreait/firebase-bundle/commit/588cc89a32fb2ddf70203efd82b52182819072fa and released with release 2.4.0 🚀

Thanks again! 🌺

eriwin commented 3 years ago

Thank you!

dgommers commented 3 years ago

@jeromegamez We appreciate your quick response on this request. Thanks again 🚀