search

kreait / firebase-php

Unofficial Firebase Admin SDK for PHP
https://firebase-php.readthedocs.io/
MIT License
2.24k stars 429 forks source link

Messaging: Add check if HTTP/2 is supported #903

Closed jeromegamez closed 4 months ago

jeromegamez commented 4 months ago

Fixes #888, https://github.com/kreait/laravel-firebase/issues/219

As reported in the issues above, environments that don't have at least cURL 7.47 (released in 2016) installed, seem unable to send FCM Messages since Release 7.10.0 of the SDK.

This PR tries to address this.

:octocat:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.10%. Comparing base (1ef4b1e) to head (fa62686).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/kreait/firebase-php/pull/903/graphs/tree.svg?width=650&height=150&src=pr&token=Azl8QCvbTQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kreait)](https://app.codecov.io/gh/kreait/firebase-php/pull/903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kreait) ```diff @@ Coverage Diff @@ ## 7.x #903 +/- ## ========================================= Coverage 91.10% 91.10% - Complexity 1583 1585 +2 ========================================= Files 156 156 Lines 4416 4416 ========================================= Hits 4023 4023 Misses 393 393 ```
jeromegamez commented 4 months ago

This apparently wasn't it 😅