search

kreait / laravel-firebase

A Laravel package for the Firebase PHP Admin SDK
https://github.com/kreait/firebase-php
MIT License
994 stars 163 forks source link

Ensure support for PHP 8.0 #109

Closed sergiy-petrov closed 2 years ago

sergiy-petrov commented 2 years ago

  1. Test against php 8.0

  2. Skip 'enabling_debug_with_a_boolean_triggers_a_deprecation' test on laravel >= 8.65.0

this is needed due to this PR - https://github.com/laravel/framework/pull/39219 in short - deprecation warnings are not treated as exceptions in laravel anymore.

  1. Migrate phpunit.xml.dist schema (./vendor/bin/phpunit --migrate-configuration)
codecov[bot] commented 2 years ago

Codecov Report

Merging #109 (1d9cdba) into main (d5b468f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                main      #109   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        47        47           
===========================================
  Files              3         3           
  Lines            130       130           
===========================================
  Hits             130       130

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5b468f...1d9cdba. Read the comment docs.

jeromegamez commented 2 years ago

Thank you @sergiy-petrov! 🌺